Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: event logging with nested chats #2600

Merged
merged 2 commits into from
May 6, 2024
Merged

Conversation

robraux
Copy link
Collaborator

@robraux robraux commented May 5, 2024

Replaces PR #2582 per @ekzhu to run the open ai tests.

Why are these changes needed?

Runtime error encountered with autogen.runtime_logging.start when using nested chats.

Related issue number

Closes #2573
Replaced PR #2582

Checks

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 22.81%. Comparing base (372ac1e) to head (abc4902).
Report is 3 commits behind head on main.

Files Patch % Lines
autogen/agentchat/conversable_agent.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2600       +/-   ##
===========================================
- Coverage   33.11%   22.81%   -10.31%     
===========================================
  Files          86       86               
  Lines        9108     9109        +1     
  Branches     1938     2090      +152     
===========================================
- Hits         3016     2078      -938     
- Misses       5837     6795      +958     
+ Partials      255      236       -19     
Flag Coverage Δ
unittests 22.76% <0.00%> (-10.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonichi sonichi enabled auto-merge May 6, 2024 18:31
@sonichi sonichi added this pull request to the merge queue May 6, 2024
Merged via the queue into main with commit ecc4113 May 6, 2024
82 of 91 checks passed
@sonichi sonichi deleted the event-logging-runtime-fix branch May 6, 2024 19:17
jayralencar pushed a commit to jayralencar/autogen that referenced this pull request May 28, 2024
Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Runtime error with autogen.runtime_logging.start, using nested chats
4 participants