Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chess example #2631

Merged
merged 1 commit into from
May 9, 2024
Merged

Fix chess example #2631

merged 1 commit into from
May 9, 2024

Conversation

thongonary
Copy link
Member

@thongonary thongonary commented May 9, 2024

Why are these changes needed?

The nested chat example for tool use in conversational chess has a few incorrect minor details, which are confusing to people.

  • In the illustration, the Player Black Agent chooses make_move(c3c5) but then the board proxy agent moves pawn from e2 to e4.
    image
  • In chess, white always moves first. The example lets black moves first, but then in the board's illustration, it's white's move.
    image

This PR fixes both of these issues:

  • Fix the illustration to make sure the moves are consistent
    image
  • Switch the initiate_chat roles so that Player White makes the first move, consistent with chess rule.
    image

Related issue number

N/A

Checks

@ekzhu ekzhu added this pull request to the merge queue May 9, 2024
@ekzhu
Copy link
Collaborator

ekzhu commented May 9, 2024

@thongonary thanks for spotting!

Merged via the queue into microsoft:main with commit 648dad5 May 9, 2024
18 checks passed
@thongonary thongonary deleted the fix_chess_example branch May 9, 2024 20:08
jayralencar pushed a commit to jayralencar/autogen that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants