Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[.Net] Fix #2660 and add tests for AutoGen.DotnetInteractive #2676

Merged
merged 4 commits into from
May 14, 2024

Conversation

LittleLittleCloud
Copy link
Collaborator

@LittleLittleCloud LittleLittleCloud commented May 13, 2024

Why are these changes needed?

This PR fixes #2660 by making RestoreDotnetInteractive to public and remove the error message check in restoring condition check.

This PR also upgrade dotnet-interactive package to the latest version and remove dependency of Microsoft.Interactive.VisualStudio. This means the user no longer need to add dotnet-tool feed before consuming AutoGen.DotnetInteractive package

Related issue number

#2660

Checks

@LittleLittleCloud LittleLittleCloud added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit ba82c1d May 14, 2024
21 checks passed
@LittleLittleCloud LittleLittleCloud deleted the u/xiaoyun/fix#2660 branch May 14, 2024 03:44
jayralencar pushed a commit to jayralencar/autogen that referenced this pull request May 28, 2024
victordibia pushed a commit that referenced this pull request Jul 30, 2024
* update

* fix 2660

* remove unnecessary feed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants