Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook on web crawling #2720

Merged
merged 21 commits into from
Oct 12, 2024
Merged

Notebook on web crawling #2720

merged 21 commits into from
Oct 12, 2024

Conversation

WilliamEspegren
Copy link

@WilliamEspegren WilliamEspegren commented May 19, 2024

Why are these changes needed?

Lacking web crawling examples in both notebooks and the docs/Example.md

Checks

Not any applicable right?

I referred to a previous pull request for inspiration while creating this notebook example for Spider. This PR provided a helpful reference for structure and content, which I have adapted to fit the specific requirements of Spider.

Twitter handle: @WilliamEspegren

@WilliamEspegren
Copy link
Author

@microsoft-github-policy-service agree

@WilliamEspegren WilliamEspegren marked this pull request as ready for review May 20, 2024 14:04
@sonichi
Copy link
Contributor

sonichi commented May 21, 2024

Thanks. Would you like the notebook to be rendered on the website? If so, https://github.com/microsoft/autogen/blob/main/notebook/contributing.md#how-to-get-a-notebook-displayed-on-the-website is the guide.

@WilliamEspegren
Copy link
Author

Thanks. Would you like the notebook to be rendered on the website? If so, https://github.com/microsoft/autogen/blob/main/notebook/contributing.md#how-to-get-a-notebook-displayed-on-the-website is the guide.

Yes please! I will look into this

@WilliamEspegren
Copy link
Author

@sonichi This notebook will be rendered on the website right?

@sonichi
Copy link
Contributor

sonichi commented May 25, 2024

@sonichi This notebook will be rendered on the website right?

Some metadata needs to be added for it to render. It's OK to do it in a separate PR if you like.

auto-merge was automatically disabled May 26, 2024 16:09

Head branch was pushed to by a user without write access

@WilliamEspegren
Copy link
Author

@sonichi Sorry for that, now it is formatted correctly and passes the checks

image

@WilliamEspegren
Copy link
Author

@sonichi Sorry for that, now it is formatted correctly and passes the checks

image

Ready to merge :)

@WilliamEspegren
Copy link
Author

@sonichi Ready to merge :)

@WilliamEspegren
Copy link
Author

@sonichi Still ready to merge 💯

@WilliamEspegren
Copy link
Author

@sonichi Should I change this PR in any way?

website/docs/Examples.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some small edits.

WilliamEspegren and others added 2 commits October 1, 2024 12:51
Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>
Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>
@ekzhu ekzhu changed the base branch from main to 0.2 October 2, 2024 18:28
@WilliamEspegren
Copy link
Author

thank you @ekzhu for the review, ready to merge now :)

@jackgerrits jackgerrits added the 0.2 Issues which were filed before re-arch to 0.4 label Oct 4, 2024
@rysweet rysweet added awaiting-op-response Issue or pr has been triaged or responded to and is now awaiting a reply from the original poster and removed awaiting-op-response Issue or pr has been triaged or responded to and is now awaiting a reply from the original poster labels Oct 10, 2024
@rysweet
Copy link
Collaborator

rysweet commented Oct 11, 2024

@ekzhu - looks like OP updated this one - can you check out the docs file conflict?

@ekzhu
Copy link
Collaborator

ekzhu commented Oct 11, 2024

@ekzhu - looks like OP updated this one - can you check out the docs file conflict?

Left a comment on an unaddressed point

Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>
@WilliamEspegren
Copy link
Author

@ekzhu sorry, fixed now :)

Copy link
Collaborator

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this for now but be aware of the upcoming new extension policy for v0.4 (currently preview) onward.

@ekzhu ekzhu merged commit 0c4ae70 into microsoft:0.2 Oct 12, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.2 Issues which were filed before re-arch to 0.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants