-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notebook on web crawling #2720
Notebook on web crawling #2720
Conversation
@microsoft-github-policy-service agree |
Thanks. Would you like the notebook to be rendered on the website? If so, https://github.com/microsoft/autogen/blob/main/notebook/contributing.md#how-to-get-a-notebook-displayed-on-the-website is the guide. |
Yes please! I will look into this |
@sonichi This notebook will be rendered on the website right? |
Some metadata needs to be added for it to render. It's OK to do it in a separate PR if you like. |
Head branch was pushed to by a user without write access
@sonichi Sorry for that, now it is formatted correctly and passes the checks |
Ready to merge :) |
@sonichi Ready to merge :) |
@sonichi Still ready to merge 💯 |
@sonichi Should I change this PR in any way? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some small edits.
Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>
Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>
thank you @ekzhu for the review, ready to merge now :) |
@ekzhu - looks like OP updated this one - can you check out the docs file conflict? |
Left a comment on an unaddressed point |
Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>
@ekzhu sorry, fixed now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging this for now but be aware of the upcoming new extension policy for v0.4 (currently preview) onward.
Why are these changes needed?
Lacking web crawling examples in both notebooks and the docs/Example.md
Checks
Not any applicable right?
I referred to a previous pull request for inspiration while creating this notebook example for Spider. This PR provided a helpful reference for structure and content, which I have adapted to fit the specific requirements of Spider.
Twitter handle: @WilliamEspegren