Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update on gpt-4o azure version date #2923

Closed
wants to merge 1 commit into from
Closed

Update on gpt-4o azure version date #2923

wants to merge 1 commit into from

Conversation

Zochory
Copy link

@Zochory Zochory commented Jun 12, 2024

For Azure gpt-4o : 2024-05-13

Why are these changes needed?

Use the latest and available version of gpt-4o on azure

Make it useable.
Note: You can deploy GPT-4o in the following US regions only at this time: eastus, eastus2, northcentralus, southcentralus, westus, westus3.
https://learn.microsoft.com/en-us/azure/ai-services/openai/concepts/models#gpt-4o-and-gpt-4-turbo

@Zochory
Update on gpt-4o azure version date
8f317cd 
For Azure gpt-4o : 2024-05-13

Note: You can deploy GPT-4o in the following US regions only at this time: eastus, eastus2, northcentralus, southcentralus, westus, westus3.
@sonichi sonichi added the studio Related to AutoGen Studio. label Jun 12, 2024
Josephrp
Josephrp reviewed Jun 12, 2024
View reviewed changes
Copy link

@Josephrp Josephrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes are not necessary or required as you simply use llm config and filter dict like normal .

worse t: hey will break all other configs by needlessly "fixing" gtp-4o by default which is shortsighted at best

@Zochory
Copy link
Author

Zochory commented Jun 12, 2024 •
edited
Loading

Hello Joseph, nice to see you too !
I see some valid argument i think i can see, but thing to note :
it's _sample mate, since nobody use gpt-4 and that gpt-4o on Azure is georestricted, and is not "Auto updated" like those who where previously (at least on ai.azure
!
image

image

Doesn't prove me right, but just to explain without being again toxic toward me, the reason of this ticket.

You act like we were in a chicken cage battle, I don't talk to you nor anything, just chill grow up a little bit, and go on.

Curious to understand the impact on the congs, if you use the same tag "gpt-4"

Anyway don't know why you still try to counter argue , a genioune ticket without any importance with so arrogance and so few forsight too.

Happy to get others feedbacks even negative it's litteraly just a tiny ticket with good intention.

@Josephrp please stop interacting with. me, especially when you don't understand the "Why are these changes needed?
Use the latest and available version of gpt-4o on azure"
Check the two images, and i might be too tired or dumb you tell me (without toxicity ifpossible)

@Zochory
Copy link
Author

Zochory commented Jun 13, 2024

Lastly for example, Copilot for Azure suggest it :
image

@qingyun-wu
Copy link
Contributor

qingyun-wu commented Jun 13, 2024 •
edited
Loading

Hi @Zochory and @Josephrp, thank you both for your input. Let's all do our best to keep the conversation constructive and friendly.

@Zochory thank you for the proposed contribution. I. think this file might be a better place to include the information you hope to include:
https://github.com/microsoft/autogen/blob/main/website/docs/topics/llm_configuration.ipynb

Another good place to include such information is this FAQs page: https://microsoft.github.io/autogen/docs/FAQ

What do you think? Thank you!

Xtrah
Xtrah suggested changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@Xtrah Xtrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed changes are a bit redundant.

This should already be covered in the standard config sample and docs, except that gpt-4o has newer API version. I suggest simply changing API version in the sample config to:

"api_version": "<your Azure OpenAI API version here>"

Leaving the rest unchanged. We could perhaps add references to where you find the correct Azure OpenAI API version for your model.

@Zochory
Copy link
Author

Zochory commented Jun 13, 2024

Hello @qingyun-wu & @Xtrah I agree with both of you to keep it more general and flexible using a "api_version": ""

One thing tho, since i made this in the autogenstudio, since some model are loaded by default in dbdefaults.json (which i don't add to the ticket in order to make it as small as possible !

Since "model": "gpt-4", and knowing the fast iterative aspect of this branch, made sense at the time, however your insights on it make sense clearly !
image

Have good day !

@ghost
Copy link

ghost commented Jun 14, 2024 via email

@Zochory
Copy link
Author

Zochory commented Jun 14, 2024

These are hackers hacking me

On Thu, Jun 13, 2024, 3:20 PM Zachary BENSALEM @.***>

wrote:

Hello @qingyun-wu https://github.com/qingyun-wu & @Xtrah

https://github.com/Xtrah I agree with both of you to keep it more

general and flexible using a "api_version": ""

One thing tho, since i made this in the autogenstudio, since some model

are loaded by default in dbdefaults.json (which i don't add to the ticket

in order to make it as small as possible !

Since "model": "gpt-4", and knowing the fast iterative aspect of this

branch, made sense at the time, however your insights on it make sense

clearly !

image.png (view on web)

https://github.com/microsoft/autogen/assets/60674042/84cc5457-471a-44c7-b605-f2aa2875956b

Have good day !

—

Reply to this email directly, view it on GitHub

#2923 (comment),

or unsubscribe

https://github.com/notifications/unsubscribe-auth/BI3MSTHGA4VOQVNMP7VRQ5LZHH5JFAVCNFSM6AAAAABJFYFYDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRWGY4TGOJYGU

.

You are receiving this because you are subscribed to this thread.Message

ID: @.***>

Hello I highly recommend to delete your API keys and check on your quota to be sure
Ping me or anyone if needed !
Hope you will be ok !

@ghost
Copy link

ghost commented Jun 14, 2024 via email

@ghost
Copy link

ghost commented Jun 14, 2024 via email

@qingyun-wu
Copy link
Contributor

These are hackers hacking me please contact fbi asap On Fri, Jun 14, 2024, 5:15 PM Zachary BENSALEM @.***> wrote:
…
These are hackers hacking me

Hi @Deykeepcomn4me, I believe your messages are irrelevant to this repo. Could you please stop spamming the repo? Thank you!

@Xtrah Xtrah mentioned this pull request Jun 15, 2024
Closed
@Hk669
Copy link
Collaborator

Hk669 commented Jun 15, 2024

@Zochory this issue is addressed in the #2948 by @Xtrah, closing this PR due to spam messages and proposed changes are redundant (from the reviewer @Xtrah), thanks for the effort to bring this issue to our notice.

@Hk669 Hk669 closed this Jun 15, 2024
@ghost
Copy link

ghost commented Jun 15, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josephrp Josephrp Josephrp left review comments

@Xtrah Xtrah Xtrah requested changes

@victordibia victordibia Awaiting requested review from victordibia

Assignees
No one assigned
Labels
studio Related to AutoGen Studio.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Zochory @qingyun-wu @Hk669 @Xtrah @Josephrp @sonichi