Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kwargs to pass to docker container that runs the Jupyter Server #3028

Merged
merged 6 commits into from
Sep 25, 2024

Conversation

rahulAira
Copy link
Contributor

Why are these changes needed?

Adding the ability to pass kwargs to docker container that runs the jupyter server helps in getting more control over the container like limiting it's compute resources, mounting volumes etc.

Related issue number

"Closes #3027"

Checks

Copy link

gitguardian bot commented Jul 20, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@nomagicln
Copy link

I think containers additional arguments should be single argument like container_kwargs rather than kwargs @rahulAira

@jackgerrits
Copy link
Member

I agree, this arg should be named more specifically. Would you like to update this PR @rahulAira?

@jackgerrits jackgerrits added this pull request to the merge queue Sep 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 25, 2024
@jackgerrits jackgerrits added this pull request to the merge queue Sep 25, 2024
Merged via the queue into microsoft:main with commit 3c10dc5 Sep 25, 2024
142 of 154 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add kwargs to Docker Jupyter Server
3 participants