-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kwargs to pass to docker container that runs the Jupyter Server #3028
Conversation
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
I think containers additional arguments should be single argument like |
I agree, this arg should be named more specifically. Would you like to update this PR @rahulAira? |
Why are these changes needed?
Adding the ability to pass kwargs to docker container that runs the jupyter server helps in getting more control over the container like limiting it's compute resources, mounting volumes etc.
Related issue number
"Closes #3027"
Checks