-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CAP] Abstraction of actor_connector to go along with runtime factory and runtime abstraction #3296
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
10404695 | Triggered | Generic High Entropy Secret | 3357b3e | test/oai/test_utils.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @rajan-chari . I saw you renamed some filenames from upper cases to lower cases, would you like to rename others?
Hi Rajan, |
Hi Ryan, |
Why are these changes needed?
AutoGen CAP comes with a default runtime, that's ready to use out of the box, to make it easy to start building Agents in minutes. However, different use cases and environments may require their own runtimes to host AutoGen CAP Agents. Runtime factories were added to make it easy to create new runtimes.
Along with runtime factories runtimes were also abstracted so that Agents/Actors can switch to different runtime implementations as needed.
This PR introduces and abstraction for agent connectors since they will depend on the needs of each runtime. Default implementation is also provided to make it super easy to start building Agents with AutoGen CAP.
Related issue number
Checks