Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to issue #3295 related to Anthropic bedrock #3298

Merged
merged 6 commits into from
Aug 9, 2024

Conversation

makkzone
Copy link
Contributor

@makkzone makkzone commented Aug 6, 2024

Why are these changes needed?

This change will allow session token to be included in the request to anthropic via amazon bedrock.

Related PR number

#3210

Related issue number

#3295

Checks

@Hk669
Copy link
Collaborator

Hk669 commented Aug 6, 2024

@makkzone have you tested this?

@sonichi sonichi requested a review from marklysze August 6, 2024 17:52
@sonichi
Copy link
Contributor

sonichi commented Aug 6, 2024

@marklysze could you find previous contributors to this feature and add them as reviewers?
@makkzone could you address the code format issue?

@sonichi sonichi requested a review from Hk669 August 6, 2024 17:53
@marklysze marklysze added the alt-models Pertains to using alternate, non-GPT, models (e.g., local models, llama, etc.) label Aug 6, 2024
@makkzone
Copy link
Contributor Author

makkzone commented Aug 7, 2024

Addressed the format issue and executed pre commit. All looks good.

Copy link
Collaborator

@marklysze marklysze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @makkzone, looks good.

@sonichi sonichi enabled auto-merge August 9, 2024 03:06
@sonichi sonichi added this pull request to the merge queue Aug 9, 2024
Merged via the queue into microsoft:main with commit fb788c3 Aug 9, 2024
137 of 151 checks passed
victordibia pushed a commit that referenced this pull request Aug 28, 2024
* Fix to consider session token in request

* Formatted

---------

Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alt-models Pertains to using alternate, non-GPT, models (e.g., local models, llama, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants