Remove dependency on RetrieveAssistantAgent for RetrieveChat #3320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkall
requested review from
Knucklessg1,
qingyun-wu,
Anush008,
marklysze and
Hk669
Anush008
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Thanks.
I will update the docs at https://qdrant.tech/documentation/frameworks/autogen/ to reflect this.
victordibia
pushed a commit
that referenced
this pull request
Aug 28, 2024
* Remove deps on RetrieveAssistantAgent for getting human input * Terminate when no more context * Add deprecation warning message * Clean up RetrieveAssistantAgent, part 1 * Update version * Clean up docs and notebooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Current RAG agents RetrieveUserProxyAgent and RetrieveAssistantAgent work together to provide RAG functionality. However, using one single RAG agent would be more convenient for group chat scenarios. At the beginning, the reason to have a RetrieveAssistantAgent instead of any AssistantAgent is that we need RetrieveAssistantAgent to help handle human input "Update Context". Now, we can handle this with
process_message_before_sendhook.So, in this PR, we remove dependency on RetrieveAssistantAgent for RetrieveChat.
Related issue number
Checks