Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax error in user-defined-functions docs (unecessarily capital… #3336

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Fix syntax error in user-defined-functions docs (unecessarily capital… #3336

merged 2 commits into from
Sep 25, 2024

Conversation

SuchitG04
Copy link
Contributor

…ized)

Why are these changes needed?

In https://microsoft.github.io/autogen/docs/topics/code-execution/user-defined-functions#provide-the-function-to-the-executor, the following code snippet (and subsequent similar ones) throws a syntax error:

code = f"""
from {LocalCommandLineCodeExecutor.FUNCTIONS_MODULE} import add_two_numbers

print(add_two_numbers(1, 2))
"""

due to FUNCTIONS_MODULE being unnecessarily capitalized.
Code being referred to:

functions_module: str = "functions",

Related issue number

I couldn't find any related issues.

Checks

Copy link
Collaborator

@randombet randombet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gagb gagb requested a review from jackgerrits September 9, 2024 05:49
@jackgerrits jackgerrits added this pull request to the merge queue Sep 25, 2024
Merged via the queue into microsoft:main with commit 0b19aa7 Sep 25, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants