Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mistral client class to support new Mistral v1.0.1 package #3356

Merged
merged 4 commits into from
Aug 16, 2024

Conversation

marklysze
Copy link
Collaborator

Mistral AI released an updated python client package, v1.0.1, which had breaking changes to code using versions before then. This updated Mistral client class has been updated to support the new version.

No new functionality has been added, but prices have been updated.

Why are these changes needed?

Existing code will not work with the latest Mistral AI (mistralai) package.

Related issue number

None, yet :).

Checks

@marklysze marklysze added the models Pertains to using alternate, non-GPT, models (e.g., local models, llama, etc.) label Aug 15, 2024
@marklysze marklysze requested a review from Hk669 August 15, 2024 19:47
@marklysze marklysze self-assigned this Aug 15, 2024
Copy link
Contributor

@Hk669 Hk669 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks @marklysze for the updates.

@Hk669 Hk669 requested a review from qingyun-wu August 16, 2024 13:16
autogen/oai/mistral.py Show resolved Hide resolved
autogen/oai/mistral.py Outdated Show resolved Hide resolved
test/oai/test_mistral.py Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 6.66667% with 28 lines in your changes missing coverage. Please review.

Project coverage is 44.88%. Comparing base (3fc708d) to head (ca334a9).

Files Patch % Lines
autogen/oai/mistral.py 6.66% 28 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3356       +/-   ##
===========================================
+ Coverage   33.33%   44.88%   +11.55%     
===========================================
  Files          95       95               
  Lines       10661    10669        +8     
  Branches     2278     2453      +175     
===========================================
+ Hits         3554     4789     +1235     
+ Misses       6791     5408     -1383     
- Partials      316      472      +156     
Flag Coverage Δ
unittest 12.10% <6.66%> (?)
unittests 44.19% <6.66%> (+10.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@randombet
Copy link
Collaborator

LGTM.

@qingyun-wu qingyun-wu added this pull request to the merge queue Aug 16, 2024
Merged via the queue into main with commit fa27396 Aug 16, 2024
134 of 146 checks passed
@qingyun-wu qingyun-wu deleted the mistralv1 branch August 16, 2024 21:01
victordibia pushed a commit that referenced this pull request Aug 28, 2024
)

* Update Mistral client class to support new Mistral v1.0.1 package

* Remove comments

* Refactored assistant/system role order, tidied imports and comments

---------

Co-authored-by: HRUSHIKESH DOKALA <96101829+Hk669@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
models Pertains to using alternate, non-GPT, models (e.g., local models, llama, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants