Fix embedding function assignment in QdrantVectorDB #3396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…faulting to FastEmbedEmbeddingFunction() otherwise
thinkall
approved these changes
Aug 22, 2024
open-autogen
pushed a commit
to autogenhub/autogen
that referenced
this pull request
Aug 22, 2024
…faulting to FastEmbedEmbeddingFunction() otherwise (microsoft#3396) Co-authored-by: Li Jiang <bnujli@gmail.com>
victordibia
pushed a commit
that referenced
this pull request
Aug 28, 2024
…faulting to FastEmbedEmbeddingFunction() otherwise (#3396) Co-authored-by: Li Jiang <bnujli@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
These changes are needed to ensure that the
QdrantVectorDBclass behaves correctly when a customembedding_functionis provided. Previously, even if a custom function was passed, the code always defaulted toFastEmbedEmbeddingFunction(), which could lead to unexpected behavior and limit the flexibility of the class. By fixing this, we ensure that the custom embedding function is properly utilized, and only default toFastEmbedEmbeddingFunction()when no custom function is specified. This enhances the reliability and correctness of the embedding process within the class.Related issue number
Checks