Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[.Net] Add AutoGen.OpenAI package that uses OpenAI v2 SDK #3402

Merged
merged 15 commits into from
Aug 27, 2024
Merged

[.Net] Add AutoGen.OpenAI package that uses OpenAI v2 SDK #3402

merged 15 commits into from
Aug 27, 2024

Conversation

LittleLittleCloud
Copy link
Collaborator

@LittleLittleCloud LittleLittleCloud commented Aug 22, 2024 •
edited
Loading

Why are these changes needed?

Related issue number

#3193

also fix #3404 and #3248

DONT MERGE

waiting for sk to release a package working with openai beta10 package

Checks

@LittleLittleCloud LittleLittleCloud mentioned this pull request Aug 22, 2024
Closed
joslat
joslat approved these changes Aug 25, 2024
View reviewed changes
Copy link

@joslat joslat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, more clean and lean. The AzureOpenAIClient is neat and better than the previous code where you had to do a configuration and "hack" it into each agent.

@LittleLittleCloud
Copy link
Collaborator Author

I like it, more clean and lean. The AzureOpenAIClient is neat and better than the previous code where you had to do a configuration and "hack" it into each agent.

100% same here,, the LLMConfig is too pythonic and not quite a good fit for .NET coding style

DavidLuong98
DavidLuong98 approved these changes Aug 27, 2024
View reviewed changes
dotnet/src/AutoGen/ConversableAgentConfig.cs Outdated Show resolved Hide resolved
dotnet/src/AutoGen/AzureOpenAIConfig.cs Outdated Show resolved Hide resolved
dotnet/sample/AutoGen.BasicSamples/Example05_Dalle_And_GPT4V.cs Show resolved Hide resolved
dotnet/sample/AutoGen.BasicSamples/Program.cs Outdated Show resolved Hide resolved
dotnet/sample/AutoGen.OpenAI.Sample/Structural_Output.cs Outdated Show resolved Hide resolved
dotnet/sample/AutoGen.BasicSamples/GettingStart/Agent_Middleware.cs Outdated Show resolved Hide resolved
@LittleLittleCloud LittleLittleCloud changed the title [.Net] Add AutoGen.OpenAI package that uses OpenAI v2 SDK [DONT MERGE NOW][.Net] Add AutoGen.OpenAI package that uses OpenAI v2 SDK Aug 27, 2024
@LittleLittleCloud LittleLittleCloud changed the title [DONT MERGE NOW][.Net] Add AutoGen.OpenAI package that uses OpenAI v2 SDK [.Net] Add AutoGen.OpenAI package that uses OpenAI v2 SDK Aug 27, 2024
@LittleLittleCloud LittleLittleCloud added this pull request to the merge queue Aug 27, 2024
Merged via the queue into main with commit 4193cea Aug 27, 2024
20 of 21 checks passed
@LittleLittleCloud LittleLittleCloud deleted the u/xiaoyun/addOpenAIV2 branch August 27, 2024 21:42
victordibia pushed a commit that referenced this pull request Aug 28, 2024
@LittleLittleCloud @victordibia
[.Net] Add AutoGen.OpenAI package that uses OpenAI v2 SDK (#3402)
e9fb076 
* udpate

* add sample to connect to azure oai

* update comment

* ping to beta5

* add openai tests

* format code

* add structural output example

* update comment

* fix test

* resolve comments

* fix format issue

* update sk version
@LittleLittleCloud LittleLittleCloud mentioned this pull request Sep 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidLuong98 DavidLuong98 DavidLuong98 approved these changes

@joslat joslat joslat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[.Net][Feature Request]: Deprecate GPTAgent
3 participants
@LittleLittleCloud @joslat @DavidLuong98