Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update application figure #352

Merged
merged 7 commits into from
Nov 27, 2023
Merged

Update application figure #352

merged 7 commits into from
Nov 27, 2023

Conversation

qingyun-wu
Copy link
Contributor

@qingyun-wu qingyun-wu commented Oct 22, 2023

Why are these changes needed?

Update application figure to match with the latest arxiv draft

Related issue number

Checks

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2023

Codecov Report

Attention: 52 lines in your changes are missing coverage. Please review.

Comparison is base (370ebf5) 29.81% compared to head (ef40920) 27.81%.
Report is 24 commits behind head on main.

Files Patch % Lines
autogen/oai/client.py 0.00% 16 Missing ⚠️
autogen/agentchat/contrib/gpt_assistant_agent.py 0.00% 11 Missing ⚠️
...gen/agentchat/contrib/retrieve_user_proxy_agent.py 0.00% 9 Missing ⚠️
autogen/oai/openai_utils.py 14.28% 6 Missing ⚠️
autogen/retrieve_utils.py 0.00% 6 Missing ⚠️
...ntchat/contrib/qdrant_retrieve_user_proxy_agent.py 0.00% 2 Missing ⚠️
autogen/oai/completion.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #352      +/-   ##
==========================================
- Coverage   29.81%   27.81%   -2.00%     
==========================================
  Files          27       27              
  Lines        3448     3480      +32     
  Branches      780      789       +9     
==========================================
- Hits         1028      968      -60     
- Misses       2346     2441      +95     
+ Partials       74       71       -3     
Flag Coverage Δ
unittests 27.75% <7.14%> (-2.00%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonichi
Copy link
Contributor

sonichi commented Oct 22, 2023

The name of A3 is too narrow.

@gagb gagb self-requested a review October 24, 2023 23:09
@sonichi sonichi added this pull request to the merge queue Nov 27, 2023
Merged via the queue into main with commit b30ead2 Nov 27, 2023
16 checks passed
@sonichi sonichi deleted the update-fig branch November 28, 2023 01:30
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* update app fig

* space

* update fig

* format

* update fig
jackgerrits pushed a commit that referenced this pull request Oct 2, 2024
* Remove commented code

* Removed unused code

* Add try except to catch json decode error

---------

Co-authored-by: afourney <adam.fourney@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants