Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Couchbase Vector DB Example Notebook and Minor Bug Fix #3804

Merged
merged 12 commits into from
Oct 17, 2024

Conversation

lokesh-couchbase
Copy link
Contributor

@lokesh-couchbase lokesh-couchbase commented Oct 16, 2024

Why are these changes needed?

Added notebook example for Couchbase vector db.

Fixed minor bugs which leaked passwords to console and added id inside the document.

Checks

Copy link

gitguardian bot commented Oct 16, 2024

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
12853598 Triggered Generic High Entropy Secret e42837d test/oai/test_utils.py View secret
10404693 Triggered Generic High Entropy Secret e42837d test/oai/test_utils.py View secret
12853599 Triggered Generic High Entropy Secret e42837d test/oai/test_utils.py View secret
10404694 Triggered Generic High Entropy Secret e42837d test/oai/test_utils.py View secret
12853601 Triggered Generic High Entropy Secret e42837d test/oai/test_utils.py View secret
10404696 Triggered Generic High Entropy Secret e42837d test/oai/test_utils.py View secret
10422482 Triggered Generic High Entropy Secret e42837d test/oai/test_utils.py View secret
12853602 Triggered Generic High Entropy Secret e42837d test/oai/test_utils.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@rysweet
Copy link
Collaborator

rysweet commented Oct 16, 2024

this gitgaurdian failure looks like a false positive to me - not sure how to resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants