Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support retrievaling assistant by name #718

Merged
merged 15 commits into from
Nov 24, 2023

Conversation

IANTHEREAL
Copy link
Collaborator

@IANTHEREAL IANTHEREAL commented Nov 19, 2023

Why are these changes needed?

support retrievaling assistant by name

Related issue number

Closes: 709

Checks

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (6087b5a) 27.69% compared to head (f3f64d2) 47.88%.

Files Patch % Lines
autogen/agentchat/contrib/gpt_assistant_agent.py 54.54% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #718       +/-   ##
===========================================
+ Coverage   27.69%   47.88%   +20.18%     
===========================================
  Files          27       27               
  Lines        3466     3479       +13     
  Branches      784      830       +46     
===========================================
+ Hits          960     1666      +706     
+ Misses       2434     1629      -805     
- Partials       72      184      +112     
Flag Coverage Δ
unittests 47.71% <72.22%> (+20.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rickyloynd-microsoft
Copy link
Contributor

@thinkall fyi

@thinkall thinkall requested a review from gagb November 19, 2023 14:44
Copy link
Contributor

@sonichi sonichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Made a few suggestions.

test/agentchat/contrib/test_gpt_assistant.py Show resolved Hide resolved
autogen/agentchat/contrib/gpt_assistant_agent.py Outdated Show resolved Hide resolved
@sonichi sonichi requested review from qingyun-wu, AaronWard, LeoLjl and a team November 19, 2023 15:36
@sonichi sonichi added the openai-assistant Issues related to assistants from OpenAI label Nov 19, 2023
@sonichi
Copy link
Contributor

sonichi commented Nov 23, 2023

@IANTHEREAL
Copy link
Collaborator Author

IANTHEREAL commented Nov 24, 2023

The test fails: https://github.com/microsoft/autogen/actions/runs/6971213911/job/18970761314

There must be an OAI Assistant named assistant under autogen openai account(https://platform.openai.com/assistants), but it had been deleted by this testing case.

Let's change a name for these test case.

@sonichi sonichi added this pull request to the merge queue Nov 24, 2023
Merged via the queue into microsoft:main with commit c705c6a Nov 24, 2023
55 of 58 checks passed
@IANTHEREAL IANTHEREAL deleted the retrieve_agent_by_name branch November 24, 2023 22:55
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* support assistant retrieval using name

* address comment

* Update autogen/agentchat/contrib/gpt_assistant_agent.py

Co-authored-by: Chi Wang <wang.chi@microsoft.com>

* make code more reading friendly

* ignore test error

* format code

* Update autogen/agentchat/contrib/gpt_assistant_agent.py

typo fix

* fix test case

---------

Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Co-authored-by: Qingyun Wu <qingyun.wu@psu.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openai-assistant Issues related to assistants from OpenAI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better name management of threads and assistants using OpenAI APIs
6 participants