Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OAI_CONFIG_LIST_sample #734

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Update OAI_CONFIG_LIST_sample #734

merged 1 commit into from
Nov 21, 2023

Conversation

Markusdreyer
Copy link
Contributor

Why are these changes needed?

The previous sample file made it seem like the model fields should be hardcoded to whatever model you're using, even for the Azure examples, which is not the case. The model should in fact be the name of the Azure model deployment.

As pointed out by @sonichi

"model" needs to be set to match the deployment_name while "deployment_name" can be removed.

Related issue number

relates to #601

Copy link
Collaborator

@victordibia victordibia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a helpful documentation update. Thanks.

@sonichi sonichi added this pull request to the merge queue Nov 21, 2023
Merged via the queue into microsoft:main with commit f6498dc Nov 21, 2023
16 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants