-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cost calculation to client #769
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #769 +/- ##
==========================================
+ Coverage 27.61% 37.21% +9.60%
==========================================
Files 27 27
Lines 3480 3493 +13
Branches 789 791 +2
==========================================
+ Hits 961 1300 +339
+ Misses 2447 2073 -374
- Partials 72 120 +48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Quite a few people are asking for cost reports, it's great to have this feature (back)!
Co-authored-by: Joshua Kim <joshkyh@users.noreply.github.com>
Co-authored-by: Joshua Kim <joshkyh@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code LGTM. Just one suggestion about documentation: We should make this feature discoverable with proper documentation or demonstration in a notebook.
Got it. I just added the print cost in the documentation. I will add a notebook about cost calculation in the next PR when implementing cost summary of a client instance. |
I'll add it to the Testbed as well, once it has progressed to the point where we're computing costs for agents and group chats. |
* add cost calculation * Update autogen/oai/client.py Co-authored-by: Joshua Kim <joshkyh@users.noreply.github.com> * Update autogen/oai/client.py Co-authored-by: Joshua Kim <joshkyh@users.noreply.github.com> * update * add doc --------- Co-authored-by: Joshua Kim <joshkyh@users.noreply.github.com>
Why are these changes needed?
Add cost calculation to client in v0.2
Related issue number
#614
Checks