-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register async human input handler #794
Conversation
@sonichi @afourney @pcdeadeasy @qingyun-wu @rickyloynd-microsoft can you guys review it.I am not able to add reviewers |
Thanks for the contribution! Is it possible to add a notebook example to demonstrate the usage and utility of this async human reply? |
yes sure let me do that |
formatting is done |
feat:updated position
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qingyun-wu should this notebook be added to the example page?
Hi @sonichi, I just left a comment on this commit. I'm wondering if this PR is a breaking change for other agents in |
I can't see the commit comment. But you are right, teachable agent and retrieve user proxy agent need to be updated. |
register reply with position argument is being used in text_analyzer_agent , teachable_agent and math_user_proxy_agent. Do we need to update it to N+1 ?? |
Hey thanks for the confirmation. I can help with a PR later today if still needed. |
…trib/ agents per PR microsoft#794
* Update conversable_agent.py * Add files via upload * Delete notebook/Async_human_input.ipynb * Add files via upload * refactor:formatter * feat:updated position --------- Co-authored-by: Chi Wang <wang.chi@microsoft.com>
…trib/ agents per PR microsoft#794 (microsoft#871) Co-authored-by: Mollie Munoz <momuno@microsoft.com>
* Update conversable_agent.py * Add files via upload * Delete notebook/Async_human_input.ipynb * Add files via upload * refactor:formatter * feat:updated position --------- Co-authored-by: Chi Wang <wang.chi@microsoft.com>
…trib/ agents per PR microsoft#794 (microsoft#871) Co-authored-by: Mollie Munoz <momuno@microsoft.com>
Summary
This PR registers the async version of the human input handler,
a_check_termination_and_human_reply
, in addition to the sync version. This allows the asynca_get_human_input
method to be leveraged during async reply generation.Why are these changes needed?
Without this change, only the sync human input method would get called during async replies. By registering the async handler, we enable async human input when needed.
Changes
self.register_reply()
call in__init__
to registerConversableAgent.a_check_termination_and_human_reply
Related issue number
closes 806
Checks
a_get_human_input
gets called as expected during async reply generation.