Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor grammar and wording issues #854

Merged
merged 8 commits into from
Dec 4, 2023
Merged

Minor grammar and wording issues #854

merged 8 commits into from
Dec 4, 2023

Conversation

qingyun-wu
Copy link
Contributor

Why are these changes needed?

  • Wording and grammar issues catched by @shruti222patel. Thank you for the catch!

Related issue number

Checks

@qingyun-wu qingyun-wu marked this pull request as ready for review December 4, 2023 02:24
@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (707d756) 26.65% compared to head (0ec6217) 26.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #854   +/-   ##
=======================================
  Coverage   26.65%   26.65%           
=======================================
  Files          28       28           
  Lines        3722     3722           
  Branches      846      846           
=======================================
  Hits          992      992           
  Misses       2658     2658           
  Partials       72       72           
Flag Coverage Δ
unittests 26.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@thinkall thinkall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @qingyun-wu for the PR. The fixes and improvements are great!

@qingyun-wu qingyun-wu added this pull request to the merge queue Dec 4, 2023
@qingyun-wu qingyun-wu removed this pull request from the merge queue due to a manual request Dec 4, 2023
@qingyun-wu qingyun-wu added this pull request to the merge queue Dec 4, 2023
Merged via the queue into main with commit c3cebd7 Dec 4, 2023
16 checks passed
@sonichi sonichi deleted the minor-fix branch December 4, 2023 04:46
rlam3 pushed a commit to rlam3/autogen that referenced this pull request Dec 19, 2023
* wording

* grammar and wording

* readability suggested by shruti222patel

* period
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* wording

* grammar and wording

* readability suggested by shruti222patel

* period
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants