Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced Independent Coverage Reporting #886

Merged
merged 6 commits into from
Dec 9, 2023

Conversation

IANTHEREAL
Copy link
Collaborator

@IANTHEREAL IANTHEREAL commented Dec 6, 2023

Why are these changes needed?

Reference #857 (comment) discussion on CI failure

Each test may require different dependencies, so they need to be run separately. And each job needs to upload the coverage report in the same way.

Checks

@IANTHEREAL IANTHEREAL marked this pull request as ready for review December 6, 2023 01:11
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (31c1664) 25.24% compared to head (4bd5db2) 38.09%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #886       +/-   ##
===========================================
+ Coverage   25.24%   38.09%   +12.84%     
===========================================
  Files          28       28               
  Lines        3728     3728               
  Branches      848      890       +42     
===========================================
+ Hits          941     1420      +479     
+ Misses       2710     2180      -530     
- Partials       77      128       +51     
Flag Coverage Δ
unittests 38.03% <ø> (+12.79%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rickyloynd-microsoft
Copy link
Contributor

@sonichi fyi

@IANTHEREAL Thanks for this! Is the PR in response to an existing issue or PR? Can you provide more details on the goals of the PR?

@IANTHEREAL
Copy link
Collaborator Author

IANTHEREAL commented Dec 6, 2023

@rickyloynd-microsoft
It comes from the discussion of the PR #857, and I have updated the PR description.

Copy link
Contributor

@sonichi sonichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestions to diversify the python versions and reduce redundant work.

.github/workflows/contrib-tests.yml Outdated Show resolved Hide resolved
.github/workflows/contrib-tests.yml Outdated Show resolved Hide resolved
@IANTHEREAL
Copy link
Collaborator Author

@sonichi PTAL again

@sonichi sonichi added this pull request to the merge queue Dec 9, 2023
Merged via the queue into microsoft:main with commit 70f4c1c Dec 9, 2023
76 checks passed
@IANTHEREAL IANTHEREAL deleted the fix-coverage-test branch December 10, 2023 01:21
rlam3 pushed a commit to rlam3/autogen that referenced this pull request Dec 19, 2023
* Independent Test Execution and Coverage Reporting

* format

* Apply suggestions from code review

Co-authored-by: Chi Wang <wang.chi@microsoft.com>

* add comments

---------

Co-authored-by: Chi Wang <wang.chi@microsoft.com>
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* Independent Test Execution and Coverage Reporting

* format

* Apply suggestions from code review

Co-authored-by: Chi Wang <wang.chi@microsoft.com>

* add comments

---------

Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants