-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced Independent Coverage Reporting #886
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #886 +/- ##
===========================================
+ Coverage 25.24% 38.09% +12.84%
===========================================
Files 28 28
Lines 3728 3728
Branches 848 890 +42
===========================================
+ Hits 941 1420 +479
+ Misses 2710 2180 -530
- Partials 77 128 +51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@sonichi fyi @IANTHEREAL Thanks for this! Is the PR in response to an existing issue or PR? Can you provide more details on the goals of the PR? |
@rickyloynd-microsoft |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small suggestions to diversify the python versions and reduce redundant work.
Co-authored-by: Chi Wang <wang.chi@microsoft.com>
@sonichi PTAL again |
* Independent Test Execution and Coverage Reporting * format * Apply suggestions from code review Co-authored-by: Chi Wang <wang.chi@microsoft.com> * add comments --------- Co-authored-by: Chi Wang <wang.chi@microsoft.com>
* Independent Test Execution and Coverage Reporting * format * Apply suggestions from code review Co-authored-by: Chi Wang <wang.chi@microsoft.com> * add comments --------- Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Why are these changes needed?
Reference #857 (comment) discussion on CI failure
Each test may require different dependencies, so they need to be run separately. And each job needs to upload the coverage report in the same way.
Checks