Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for async group chat #902

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

tyler-suard-parker
Copy link
Contributor

@tyler-suard-parker tyler-suard-parker commented Dec 7, 2023

Issue #543 has been on hold for 3 weeks, due to not having tests for groupchat. I added a test for groupchat, so hopefully now we can use AutoGen to call OpenAI asynchronously.

  • I've added tests (if relevant) corresponding to the changes introduced in this PR.
  • I've made sure all auto checks have passed.

@tyler-suard-parker
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Parker Hannifin"

@tyler-suard-parker
Copy link
Contributor Author

tyler-suard-parker commented Dec 7, 2023

@qingyun-wu @sonichi @kittyandrew I made this to hopefully merge #543 so we can have async calls to OpenAI.

@qingyun-wu
Copy link
Contributor

@qingyun-wu @sonichi @kittyandrew I made this to hopefully merge #543 so we can have async calls to OpenAI.

Thanks! I will take a look at this soon.

@qingyun-wu
Copy link
Contributor

Could you run pre-commit to regulate code format? Thank you!

@qingyun-wu qingyun-wu self-requested a review December 7, 2023 16:36
@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cbd1e19) 26.58% compared to head (a9cf2f9) 37.35%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #902       +/-   ##
===========================================
+ Coverage   26.58%   37.35%   +10.77%     
===========================================
  Files          28       28               
  Lines        3732     3732               
  Branches      847      889       +42     
===========================================
+ Hits          992     1394      +402     
+ Misses       2667     2197      -470     
- Partials       73      141       +68     
Flag Coverage Δ
unittests 37.19% <ø> (+10.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@qingyun-wu qingyun-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed code format issues. LGTM now! Thank!

@qingyun-wu qingyun-wu added this pull request to the merge queue Dec 7, 2023
Merged via the queue into microsoft:main with commit e96213e Dec 7, 2023
19 checks passed
@tyler-suard-parker
Copy link
Contributor Author

Fixed code format issues. LGTM now! Thank!

I am very proud to be a contributor to such an important Microsoft repo!

@tyler-suard-parker
Copy link
Contributor Author

@qingyun-wu I have some very bad news. I just built autogen from source with the new merges and it is STILL not running async, at least for me.

rlam3 pushed a commit to rlam3/autogen that referenced this pull request Dec 19, 2023
* Add test for async group chat

* run pre-commit

---------

Co-authored-by: Qingyun Wu <qingyun.wu@psu.edu>
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* Add test for async group chat

* run pre-commit

---------

Co-authored-by: Qingyun Wu <qingyun.wu@psu.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants