-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable allow_repeat_speaker to be a list of agents #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o repeat, rather than just a global boolean.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #905 +/- ##
==========================================
- Coverage 26.46% 24.04% -2.43%
==========================================
Files 28 26 -2
Lines 3801 3797 -4
Branches 865 865
==========================================
- Hits 1006 913 -93
- Misses 2724 2761 +37
- Partials 71 123 +52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sonichi
approved these changes
Dec 7, 2023
rlam3
pushed a commit
to rlam3/autogen
that referenced
this pull request
Dec 19, 2023
…o repeat, rather than just a global boolean. (microsoft#905) Co-authored-by: Qingyun Wu <qingyun.wu@psu.edu>
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
* add cost budget; move loc of make_dir * support openai completion * install pytest in workflow * skip openai test * test openai * path for docs rebuild * install datasets * signal * notebook * notebook in workflow * optional arguments and special params * key -> k * improve readability * assumption * optimize for model selection * larger range of max_tokens * notebook * python package workflow * skip on win
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
…o repeat, rather than just a global boolean. (microsoft#905) Co-authored-by: Qingyun Wu <qingyun.wu@psu.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
At present, allow_repeat_speaker must be a boolean. If True, then all agents can repeat. If False, then no agents can repeat. This PR allows developers to assign a list to allow_repeat_speaker. If an agent is in the list, then it is allowed to speak consecutively (if the GroupChat desires), otherwise it cannot repeat. This is useful because some agents benefit from repetition (e.g., the AssistantAgent), where others really should not repeat (e.g., the UserProxy).
Related issue number
N/A
Checks