Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default model and config loading process in AgentBuilder #917

Merged
merged 16 commits into from
Dec 8, 2023

Conversation

LinxinS97
Copy link
Collaborator

@LinxinS97 LinxinS97 commented Dec 8, 2023

Why are these changes needed?

  • Default builder and agent model should not use the model under preview.
  • AgentBuilder should not let users specify the builder and agent models when loading previous configs. Builder model should only be created when use_api=True. Some severe issues will happen when users specify a model according to the config list the first time and forget it later.

This PR is not ready to merge.

TODO:
Implement load() directly read JSON.

Related issue number

Checks

  • I've made sure all auto checks have passed.

@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (69aaea5) 26.58% compared to head (0734cc0) 54.68%.
Report is 1 commits behind head on main.

Files Patch % Lines
autogen/agentchat/contrib/agent_builder.py 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #917       +/-   ##
===========================================
+ Coverage   26.58%   54.68%   +28.10%     
===========================================
  Files          28       28               
  Lines        3732     3732               
  Branches      847      889       +42     
===========================================
+ Hits          992     2041     +1049     
+ Misses       2667     1480     -1187     
- Partials       73      211      +138     
Flag Coverage Δ
unittests 54.47% <80.00%> (+27.94%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonichi sonichi added this pull request to the merge queue Dec 8, 2023
Merged via the queue into main with commit 8ea6377 Dec 8, 2023
81 of 84 checks passed
@sonichi sonichi deleted the autobuild branch December 9, 2023 20:06
rlam3 pushed a commit to rlam3/autogen that referenced this pull request Dec 19, 2023
…osoft#917)

* try to fix blog

* modify blog

* fix test error in microsoft#717; fix blog typo in installation; update blogs with output examples.

* pre-commit

* pre-commit

* Update website/blog/2023-11-26-Agent-AutoBuild/index.mdx

Co-authored-by: Qingyun Wu <qingyun.wu@psu.edu>

* add future work

* fix grammar

* update agent_builder

---------

Co-authored-by: Jieyu Zhang <jieyuz2@cs.washington.edu>
Co-authored-by: Qingyun Wu <qingyun.wu@psu.edu>
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
…osoft#917)

* try to fix blog

* modify blog

* fix test error in microsoft#717; fix blog typo in installation; update blogs with output examples.

* pre-commit

* pre-commit

* Update website/blog/2023-11-26-Agent-AutoBuild/index.mdx

Co-authored-by: Qingyun Wu <qingyun.wu@psu.edu>

* add future work

* fix grammar

* update agent_builder

---------

Co-authored-by: Jieyu Zhang <jieyuz2@cs.washington.edu>
Co-authored-by: Qingyun Wu <qingyun.wu@psu.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants