Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testbed quality of life improvement: Stream docker to console. #947

Closed
wants to merge 1 commit into from

Conversation

afourney
Copy link
Member

Why are these changes needed?

Previously testbed logs were printed only after the scenario had completed, and Docker exited. However, scenarios often were very long, and could take minutes to conclude. If watching a test in real-time, this was a long time to wait to see how the task was going.

This PR turns on Docker streaming, and allows you to monitor experiments in real-time.

Related issue number

N/A

Checks

@afourney afourney added the autogenbench Issues related to AutoGenBench. label Dec 12, 2023
@afourney afourney requested review from qingyun-wu, yiranwu0 and a team December 12, 2023 05:43
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3a768c3) 26.63% compared to head (0e61254) 26.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #947   +/-   ##
=======================================
  Coverage   26.63%   26.63%           
=======================================
  Files          28       28           
  Lines        3777     3777           
  Branches      858      858           
=======================================
  Hits         1006     1006           
  Misses       2700     2700           
  Partials       71       71           
Flag Coverage Δ
unittests 26.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afourney
Copy link
Member Author

Superseded by #1048

@afourney afourney closed this Dec 22, 2023
@afourney afourney deleted the testbed_streaming_docker branch January 23, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autogenbench Issues related to AutoGenBench.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants