Groupchat send introductions #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #961 +/- ##
===========================================
+ Coverage 39.62% 67.81% +28.18%
===========================================
Files 57 57
Lines 6006 6021 +15
Branches 1338 1461 +123
===========================================
+ Hits 2380 4083 +1703
+ Misses 3433 1569 -1864
- Partials 193 369 +176
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sonichi
approved these changes
Feb 15, 2024
sonichi
reviewed
Feb 15, 2024
|
@jackgerrits @ekzhu we should consider this PR for generalizing the issue that we also identified for executors + two agents. |
ekzhu
approved these changes
Feb 24, 2024
|
@afourney how do you benchmark that improvements were made? was there a published article? and how are we able to get access to the introduction message? thanks! |
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
* indentation space microsoft#884 changing indentation of python code blocks * indentation space microsoft#884 changing indentation of python code blocks 2
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
* Allow the GroupChatManager to send introductions. * Fixed function name. * Added test cases for sending introductions. * Trying to sort out why remote pytest is failing. * Fixed broken plugin behavior. * Update autogen/agentchat/groupchat.py Co-authored-by: Chi Wang <wang.chi@microsoft.com> * Updated as per Chi's suggestions. --------- Co-authored-by: Chi Wang <wang.chi@microsoft.com> Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
By default, only the GroupChatManager knows the full list of agents participating in a GroupChat discussion. This can be problematic, as an agent may make different choices if it knows who else is present. For example, an assistant my choose to write code to crawl a webpage if there is no web_surfer agent present, but may instead ask the web_surfer to fetch the website when they are present.
This PR adds an optional flag (False by default) for the GroupChatManager to send a round of introductions to agents before a conversation starts. These introductions do not require LLM calls and do not count toward max_round.
Related issue number
N/A
Checks