Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added skip setting for 1ES PT tag in PR pipeline #1213

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

v-viyada
Copy link
Contributor

@v-viyada v-viyada commented Jan 30, 2024

Details

1ES PT adds tags to pipeline runs using the access token provided by ADO. In the case of pipeline runs against forked repos of a GitHub repo, the access token does not have Edit build quality permissions and hence cannot add tags. To unblock those pipelines, skipped tagging by using the option SkipBuildTagsForGitHubPullRequests.

Verified that the only change in the pipeline run is that it do not add "1ES.PT.Unofficial" tag on the Run. In place of that it adds below warning message.

##[warning]1ES PT Warning: Skipping build tags as this build is a pull request form GitHub which does not have permissions to add tags.

Motivation
Context

Pull request checklist

  • PR title respects Conventional Commits (starts with fix:, feat:, etc, and is suitable for user-facing release notes)
  • [na] PR contains no breaking changes, OR description of both PR and final merge commit starts with BREAKING CHANGE:
  • [na] (if applicable) Addresses issue: #0000
  • [na] Added relevant unit tests for your changes
  • Ran yarn precheckin
  • [na] Verified code coverage for the changes made

@v-viyada v-viyada marked this pull request as ready for review January 30, 2024 00:46
@v-viyada v-viyada requested a review from a team as a code owner January 30, 2024 00:46
@v-viyada v-viyada merged commit 0aca55d into microsoft:main Jan 30, 2024
4 checks passed
@ada-cat
Copy link
Collaborator

ada-cat commented Mar 28, 2024

🎉 This PR is included in version 2.11.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants