Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(axe-core-4.10.2): update to use axe-core 4.10.2 #1395

Merged
merged 8 commits into from
Nov 8, 2024
Merged

feat(axe-core-4.10.2): update to use axe-core 4.10.2 #1395

merged 8 commits into from
Nov 8, 2024

Conversation

JeevaniChinthala
Copy link
Contributor

@JeevaniChinthala JeevaniChinthala commented Sep 18, 2024 •
edited by v-viyada
Loading

Details

This PR upgrades axe-core to 4.10.2 according to the instructions in CONTRIBUTING.md.

Motivation

feature work 🚀

Context

Pull request checklist

  • PR title respects Conventional Commits (starts with fix:, feat:, etc, and is suitable for user-facing release notes)
  • PR contains no breaking changes, OR description of both PR and final merge commit starts with BREAKING CHANGE:
  • Verify PR title and final merge commit contain space after : for example feat(feature): feature title otherwise it will not be considered by semantic-release for release.
  • (if applicable) Addresses issue: #0000
  • Added relevant unit tests for your changes
  • Ran yarn precheckin
  • Verified code coverage for the changes made

@JeevaniChinthala
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JeevaniChinthala JeevaniChinthala changed the title feat(axe-core-4.10.0): update to use axe-core 4.10.0 feat(axe-core-4.10.1): update to use axe-core 4.10.1 Oct 17, 2024
@v-viyada v-viyada changed the title feat(axe-core-4.10.1): update to use axe-core 4.10.1 feat(axe-core-4.10.2): update to use axe-core 4.10.2 Oct 24, 2024
@v-viyada v-viyada marked this pull request as ready for review October 24, 2024 18:08
@v-viyada v-viyada requested a review from a team as a code owner October 24, 2024 18:08
madalynrose
madalynrose requested changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@madalynrose madalynrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally looks as expected except I think the files and updates for versions 4.10.0 and 4.10.1 are superfluous. I think we only need new files and tests for 4.10.2.

src/index.test.ts Outdated Show resolved Hide resolved
@v-sharmachir v-sharmachir mentioned this pull request Nov 8, 2024
Closed
@v-sharmachir v-sharmachir merged commit 14d54d8 into main Nov 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JGibson2019 JGibson2019 JGibson2019 approved these changes

@madalynrose madalynrose madalynrose approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JeevaniChinthala @madalynrose @JGibson2019 @v-sharmachir