Add ScanOptions.NativeWindowHandle to scope Scans to rooted UIA sub-tree #1022
Conversation
… for the root element of the UIA subtree that should be scanned.
|
@JGibson2019 Proposed change to allow ScanOptions to limit the scope of the Scan |
|
Please update the documentation ( |
…le -> TargetElementLocator.LocateRootElements instead of setting a field on the ScanTools' TargetElementLocator.
…nUtilities class in AutomationTests.
… an IUIAutomationElement.
…l that has nonzero HWND for scoped UI scan testing.
…ldlifeManager_ValidRoot, ensure valid HWND is passed to Scanner.
|
@DaveTryon @codeofdusk Thanks for reviewing. I believe I've addressed all the comments from the first iteration. Would you please take a second look? |
|
@blackcatsonly Please update the |
|
@codeofdusk Thanks, missed than one! Updated in latest iteration. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -3,6 +3,8 @@ | |||
|
|
|||
| namespace Axe.Windows.Automation | |||
| { | |||
| using System; | |||
There was a problem hiding this comment.
Move using to outside namespace declaration
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1022 +/- ##
==========================================
- Coverage 73.70% 72.21% -1.49%
==========================================
Files 398 424 +26
Lines 12046 13158 +1112
Branches 0 1413 +1413
==========================================
+ Hits 8878 9502 +624
- Misses 3168 3243 +75
- Partials 0 413 +413 ☔ View full report in Codecov by Sentry. |
…actual format to clarify why comparisons failed.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Thanks @codeofdusk! |
Details
Adds:
Motivation
Proposal to address issue #1021
Context
I exposed internals of A11yAutomation to the Integration Tests project so I could find a relevant IUIAutomationElement for testing the ScanOptions' HWND constraint
You could implement this as a "ForWindowHandle()" constraint on the Config, but my external tools use the same scanner repeatedly - it's the individual Scans whose scope needs to be constrained.
Pull request checklist