Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to support Node 16 #99

Merged
merged 11 commits into from
Oct 17, 2023
Merged

Changes to support Node 16 #99

merged 11 commits into from
Oct 17, 2023

Conversation

madkoo
Copy link
Collaborator

@madkoo madkoo commented Sep 29, 2023 •
edited
Loading

Changes to support Node16

  • add V2 for emailReportTask
  • V2 should support Node16
  • Add pipeline to automate deployment
  • restructure, rename manifest file
  • update required pacakges
  • rename V2 extension
  • rename to V1, add new package commands
  • restructure extension, add webpack to package application
  • resturcure, setup packagin for dev and release
  • add initial pipeline to build, package and deploy emailReporting extension

@madkoo madkoo marked this pull request as ready for review October 4, 2023 06:00
@madkoo madkoo requested a review from MOlausson October 4, 2023 06:01
@MOlausson
Copy link
Collaborator

@madkoo there's a lot of added intermediary files that I don't think should be committed. Can you clean that up so it's easier to do the review?

@madkoo
Copy link
Collaborator Author

madkoo commented Oct 5, 2023

@MOlausson , indeed included files that shouldn't have gone in. Cleaned up now.

MOlausson
MOlausson reviewed Oct 17, 2023
View reviewed changes
configs/dev.json Outdated Show resolved Hide resolved
@madkoo @MOlausson
Update configs/dev.json
b43b016 
Co-authored-by: Mathias Olausson <mathias@olausson.net>
MOlausson
MOlausson approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@MOlausson MOlausson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@MOlausson MOlausson merged commit 123182c into master Oct 17, 2023
1 of 2 checks passed
@MOlausson MOlausson deleted the feature/upgrade-node-target branch October 17, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MOlausson MOlausson MOlausson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madkoo @MOlausson