Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node versions 6, 10 and 14 to the unit tests #465

Merged
merged 19 commits into from
Sep 13, 2021

Conversation

kuleshovilya
Copy link
Contributor

@kuleshovilya kuleshovilya commented Sep 7, 2021

Add node versions 6, 10 and 14 to the unit tests, change install directory for tests on node 6, add different expectedString for node 6

@kuleshovilya kuleshovilya changed the title Add node versiobs 6,10 and 14 to the unit tests Add node versions 10 and 14 to the unit tests Sep 7, 2021
Copy link
Contributor

@anatolybolshakov anatolybolshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for node 6 also

@kuleshovilya kuleshovilya changed the title Add node versions 10 and 14 to the unit tests Add node versions 6, 10 and 14 to the unit tests Sep 9, 2021
make.js Outdated Show resolved Hide resolved
test/units/tests.ts Show resolved Hide resolved
make.js Show resolved Hide resolved
@kuleshovilya kuleshovilya merged commit 08377d0 into master Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants