Merge pull request #247 from microsoft/users/tedchamb/dev5

Move back to beta, until I can look at the two open issues.
microsoft · Jul 25, 2019 · f708734 · f708734
2 parents 9ca0779 + 143e245
commit f708734
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 10 deletions.
diff --git a/azure-devops/azure/devops/client.py b/azure-devops/azure/devops/client.py
@@ -124,24 +124,23 @@ def _create_request_message(self, http_method, location_id, route_values=None,
             route_values = {}
         route_values['area'] = location.area
         route_values['resource'] = location.resource_name
-        route_template = self._remove_optional_route_parameters(location.route_template,
-                                                                route_values)
+        url = self._transform_route_template(location.route_template, route_values)
         logger.debug('Route template: %s', location.route_template)
-        url = self._client.format_url(route_template, **route_values)
         request = ClientRequest(method=http_method, url=self._client.format_url(url))
         if query_parameters:
             request.format_parameters(query_parameters)
         return request
 
     @staticmethod
-    def _remove_optional_route_parameters(route_template, route_values):
+    def _transform_route_template(route_template, route_values):
         new_template = ''
         route_template = route_template.replace('{*', '{')
         for path_segment in route_template.split('/'):
             if (len(path_segment) <= 2 or not path_segment[0] == '{'
-                    or not path_segment[len(path_segment) - 1] == '}'
-                    or path_segment[1:len(path_segment) - 1] in route_values):
+                    or not path_segment[len(path_segment) - 1] == '}'):
                 new_template = new_template + '/' + path_segment
+            elif path_segment[1:len(path_segment) - 1] in route_values:
+                new_template = new_template + '/' + route_values[path_segment[1:len(path_segment) - 1]]
         return new_template
 
     def _get_resource_location(self, location_id):
@@ -222,7 +221,7 @@ def _negotiate_request_version(location, version):
         else:
             # We can send at the requested api version. Make sure the resource version
             # is not bigger than what the server supports
-            negotiated_version = str(requested_api_version)
+            negotiated_version = match.group(1)
             is_preview = match.group(3) is not None
             if is_preview:
                 negotiated_version += '-preview'
@@ -267,7 +266,7 @@ def _handle_error(self, request, response):
             raise AzureDevOpsAuthenticationError(full_message_format.format(error_message=error_message,
                                                                             url=request.url))
         else:
-            full_message_format = '{error_message}Operation returned an invalid status code of {status_code}.'
+            full_message_format = '{error_message}Operation returned a {status_code} status code.'
             raise AzureDevOpsClientRequestError(full_message_format.format(error_message=error_message,
                                                                            status_code=response.status_code))
 

diff --git a/azure-devops/azure/devops/version.py b/azure-devops/azure/devops/version.py
@@ -3,4 +3,4 @@
 # Licensed under the MIT License. See License.txt in the project root for license information.
 # --------------------------------------------------------------------------------------------
 
-VERSION = "5.1.0"
+VERSION = "5.1.0b1"
diff --git a/azure-devops/setup.py b/azure-devops/setup.py
@@ -6,7 +6,7 @@
 from setuptools import setup, find_packages
 
 NAME = "azure-devops"
-VERSION = "5.1.0"
+VERSION = "5.1.0b1"
 
 # To install the library, run the following
 #