-
Notifications
You must be signed in to change notification settings - Fork 866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework resource monitor #4803
Merged
vmapetr
merged 14 commits into
master
from
v-mpetrov/us-2173920-resource-monitor-performance-fix
Jun 17, 2024
Merged
Rework resource monitor #4803
vmapetr
merged 14 commits into
master
from
v-mpetrov/us-2173920-resource-monitor-performance-fix
Jun 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmapetr
force-pushed
the
v-mpetrov/us-2173920-resource-monitor-performance-fix
branch
from
May 27, 2024 22:33
883a749
to
856ff5a
Compare
vmapetr
force-pushed
the
v-mpetrov/us-2173920-resource-monitor-performance-fix
branch
from
May 30, 2024 23:22
363464d
to
ed4c4c2
Compare
ivanduplenskikh
approved these changes
Jun 3, 2024
DmitriiBobreshev
approved these changes
Jun 3, 2024
KonstantinTyukalov
approved these changes
Jun 5, 2024
kirill-ivlev
approved these changes
Jun 11, 2024
martin-toman
approved these changes
Jun 17, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks resource monitor methods to improve the resource monitors and fix the issue with the performance degradation on Windows machines.
WI: 2173920
Changes:
ManagementObjectSearcher
queries instead of direct calls of the deprecatedWMIC.exe
Testing:
Validated on Windows 11 / Ubuntu 22.04 / MacOS 14.0