Add node 20 support to task-lib for testing and pick highest node version for tests #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion for tests - Added node 20 support - Changed the logic to pick highest handler instead of first one - Added tests for node20 - Changed tests for node6, node10, node16 to use highest handler
KonstantinTyukalov
approved these changes
May 22, 2024
kirill-ivlev
approved these changes
May 23, 2024
DergachevE
reviewed
May 24, 2024
…sion for tests - Bumped node version
…sion for tests - Fix test for node20
DergachevE
reviewed
May 27, 2024
…sion for tests - code review feedback
DergachevE
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related WI: 2180233
Testing:
Tested locally with different tasks with node 16 and node20 handlers