Fix debug logs inside user commands #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleksandrlevochkin
approved these changes
Sep 6, 2024
kirill-ivlev
approved these changes
Sep 9, 2024
DergachevE
approved these changes
Sep 9, 2024
DmitriiBobreshev
approved these changes
Sep 9, 2024
KonstantinTyukalov
deleted the
users/KonstantinTyukalov/Fix_logs_on_exit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes 'exit' event raises when stdout is not yet flushed leading to case when debug log injected between tool output chunks.
This PR moves all debug logs related to process 'exit' and 'close' events to the place where stdout should be already closed.
WI: AB#2180742