Migration to @azure/storage-blob library with a fix
#258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitriiBobreshev
approved these changes
Dec 7, 2023
DergachevE
approved these changes
Dec 7, 2023
vmapetr
approved these changes
Dec 7, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This migration was attempted in this PR previously: #223 but resulted in a couple of issues:
@azure/storage-blob's support for older Node versions such as v10AzureVmssDeployment@0task (described in Incident 440618138) because parts of blob URLs were concatenated incorrectlyThen the migration was reverted in #256
Solution
globalThisbecause it was missing in Node 10Testing
Tested the updated common package with the task JavaToolInstallerV0
Also tested how the blob URLs to custom scripts are created with
AzureVmssDeploymentV0