Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AzureResourceManagerTemplateDeployment] - Fix for bicep param file with multiple extensions #19581

Merged

Conversation

Cadacious
Copy link
Contributor

Task name: AzureResourceManagerTemplateDeployment

Description: Fixes .bicepparam file support to work when bicep param file has multiple file extensions like main.ENVNAME.bicepparm it results in a main.parameters.json file as expected.

This new code will now properly detect when more than one file extension is applied and properly remove all file extensions before replacing with .parameters.json.

Documentation changes required: No

Added unit tests: Yes, unit test was added to cover this use case

Attached related issue: Yes, Comment on previous PR with this issue

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

Link to pipeline run with new version of task code

Passing unit tests:
image

@Cadacious
Copy link
Contributor Author

@v-mohithgc can we get the process started to get this run in the validation pipelines and reviewed if it passes all checks please?

@v-mohithgc
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@v-mohithgc
Copy link
Contributor

/azp run

@v-mohithgc v-mohithgc enabled auto-merge (squash) February 29, 2024 05:09
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@v-mohithgc v-mohithgc merged commit 67e1fd6 into microsoft:master Feb 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants