Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CargoAuthenticateV0 Register as secret for basic cargo auth #19905

Merged
merged 7 commits into from
May 23, 2024

Conversation

embetten
Copy link
Contributor

Task name: CargoAuthenticateV0

Description: Register environment variables as secret

Documentation changes required: (Y/N) N

Added unit tests: (Y/N) N

Attached related issue: (Y/N) N/A

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@embetten embetten requested a review from a team as a code owner May 23, 2024 18:21
@embetten embetten changed the title CargoAuthenticateV0 set secret on basic cargo auth CargoAuthenticateV0 Register as secret for basic cargo auth May 23, 2024
@jmyersmsft
Copy link
Member

jmyersmsft commented May 23, 2024

Isn't there supposed to be a bunch of junk under _generated? I think you have to build the repo. Otherwise LGTM

@embetten embetten enabled auto-merge (squash) May 23, 2024 18:34
@embetten embetten merged commit 5099bc9 into master May 23, 2024
11 checks passed
@embetten embetten deleted the users/embetten/cargo-auth-env-variables branch May 23, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants