Pin urllib3 to fix issue with vcrpy #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuzminrobin
approved these changes
May 23, 2023
This was referenced Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces (and based on) #464.
vcrpyis incompatible with the latesturllib32.0.2(kevin1024/vcrpy#688).This PR is a temporary workaround to pin some older versions of the dependencies to unblock our test pipelines.
We take an indirect dependency on
vcrpyandurllib3from theazure-devtoolpackage, which contains the Azure SDK test infrastructure.Once
vcrpyis fixed andazure-devtoolpicks the fix, we can undo this workaround.