Fix logic to error on duplicate package names and add test #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecraig12345
force-pushed
the
ecraig/packageInfos2
branch
from
3b45348 to
39b8609
Compare
kenotron
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#759 didn't work due to the logic being in the wrong function and not having tests... This PR fixes the issue and adds tests.
While writing the test, I noticed that whileEDIT: fixing beachball types is like poking a dragon...fixing one thing reveals that everything is wrong. 🤦♀️ So this is reverted.packageInfo.combinedOptionscontains everything fromBeachballOptionsin practice, that wasn't reflected in the types, so I also updated the types.Note that I renamed the old change file (since it hasn't been published yet) in addition to making a new minor change file for the typing change.