This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Better readme instructions #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanlouie
reviewed
Jan 10, 2019
README.md
Outdated
| @@ -78,6 +83,7 @@ $ export TF_VAR_grafana_admin_password="SECRETpass" | |||
| 5. Deploy the dev configuration: | |||
|
|
|||
| ``` | |||
| bash-4.4# helm update | |||
There was a problem hiding this comment.
should be helm repo update
There was a problem hiding this comment.
yes - per the latest helm helm update has been deprecated in favor of helm repo update
evanlouie
reviewed
Jan 10, 2019
infra/environments/dev/init
Outdated
| @@ -4,5 +4,6 @@ rm -rf .terraform | |||
| rm terraform.tfstate | |||
| rm terraform.tfstate.backup | |||
|
|
|||
| helm update | |||
There was a problem hiding this comment.
should be helm repo update
bnookala
force-pushed
the
update-readme
branch
from
c143b53
to
7f40c35
Compare
|
Looks great - thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions left me a little bit confused when creating a cluster for the first time - this should help with that a bit.