Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SingleFilePublish issue #311

Merged
merged 3 commits into from
Nov 30, 2020

Conversation

eddynaka
Copy link
Contributor

No description provided.

&& this.CodeViewDebugDirectoryData.Path != null
&& this.CodeViewDebugDirectoryData.Path.EndsWith("apphost.pdb", StringComparison.OrdinalIgnoreCase);
&& (this.CodeViewDebugDirectoryData.Path?.EndsWith("apphost.pdb", StringComparison.OrdinalIgnoreCase) == true
|| this.CodeViewDebugDirectoryData.Path?.EndsWith("singlefilehost.pdb", StringComparison.OrdinalIgnoreCase) == true);
Copy link
Member

@michaelcfanning michaelcfanning Nov 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(this.CodeViewDebugDirectoryData.Path?.EndsWith("apphost.pdb", StringComparison.OrdinalIgnoreCase).Value ||
this.CodeViewDebugDirectoryData.Path?.EndsWith("singlefilehost.pdb", StringComparison.OrdinalIgnoreCase).Value);

Copy link
Member

@michaelcfanning michaelcfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@eddynaka eddynaka marked this pull request as ready for review November 30, 2020 23:30
@eddynaka eddynaka merged commit b65aa37 into main Nov 30, 2020
@eddynaka eddynaka deleted the users/ednakamu/fixing-singlefilepublish-issue branch November 30, 2020 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants