Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging UnauthorizedAccessException in BotFrameworkHttpAdapter #6784

Merged
merged 1 commit into from
May 7, 2024
Merged

Logging UnauthorizedAccessException in BotFrameworkHttpAdapter #6784

merged 1 commit into from
May 7, 2024

Conversation

tracyboehrer
Copy link
Member

#minor

Makes it easier to see auth errors due to misconfiguration.

@tracyboehrer tracyboehrer added the Automation: No parity PR does not need to be applied to other languages. label May 7, 2024
@tracyboehrer tracyboehrer requested a review from a team as a code owner May 7, 2024 17:59
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 388816

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 35 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.002%) to 78.163%
Files with Coverage Reduction New Missed Lines %
/libraries/AdaptiveExpressions/LRUCache.cs 4 87.18%
/libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/BotFrameworkHttpAdapter.cs 31 50.93%
Totals Coverage Status
Change from base Build 388810: -0.002%
Covered Lines: 26187
Relevant Lines: 33503
💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 673dbca into main May 7, 2024
9 of 11 checks passed
@tracyboehrer tracyboehrer deleted the tracyboehrer/adapter-auth-logging branch May 7, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Automation: No parity PR does not need to be applied to other languages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tracyboehrer @coveralls