refactor: Add Recognizers-Text packages to botbuilder-stdlib #4660
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#minor
Related PR: #4661
Description
This PR adds https://github.com/microsoft/Recognizers-Text into
botbuilder-stdlib
library, so it's easier to update vulnerable dependencies without introducing breaking changes.botbuilder-stdlib
is an internal library that contains helper functions which the rest of botbuilder libraries use. Therefore, we included the Recognizers-Text packages under thevendors
folder, so botbuilder libraries can consume them.Specific Changes
libraries/botbuilder-repo-utils/src/workspace.ts
to search workspaces, taking into account.gitignore
and the location where the command is run. Otherwise, it will cause unwanted behaviors where nested dependencies insidenode_modules
were considered as a workspace.vendors
folder.botbuilder-stdlib
package.json, so they are installed properly.types
references to match each Recognizers-Text package insidebotbuilder-stdlib
.Testing
The following image shows the bot working with the new Recognizers-Text packages inside BotBuilder.
![imagen](https://private-user-images.githubusercontent.com/62260472/327844320-9a6d6a9e-4d85-45ce-8083-bf961564cf33.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMjAxOTgsIm5iZiI6MTczOTMxOTg5OCwicGF0aCI6Ii82MjI2MDQ3Mi8zMjc4NDQzMjAtOWE2ZDZhOWUtNGQ4NS00NWNlLTgwODMtYmY5NjE1NjRjZjMzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDAwMjQ1OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTEzMjIwYWVmMWMyZDA5MWZiNjEzODIyNjI1Y2I1Njc0ODdkYmNiNDk1ZTE0Zjk5NDFiMjdlNzliMmJmYjM4YTkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.eRp-QpiE2Y8E4HoWEA4Vm0TiqAXAAfBnz68mkR5H7Ko)