Adding luis:application:list cmd #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
munozemilio
reviewed
Nov 21, 2019
| help: flags.help({char: 'h'}), | ||
| endpoint: flags.string({description: 'LUIS endpoint hostname'}), | ||
| subscriptionKey: flags.string({description: 'LUIS cognitive services subscription key (aka Ocp-Apim-Subscription-Key)'}), | ||
| out: flags.string({char: 'o', description: 'Path to the directory where the exported file will be placed.'}), |
There was a problem hiding this comment.
Spec states: Output results to specified file in JSON format, otherwise prints to STDOUT (optional)
Which suggests a file name can also be set as output, in the other hand, for this command I don't think there is a lot of value printing this to a file. @scheyal please comment
There was a problem hiding this comment.
suggest we just move fwd since it's already coded...discuss removing --out (if desired) later
There was a problem hiding this comment.
Can we set the description as the spec please?
|
fixes #308 |
…oft/botframework-cli into 308-luis-application-list
…oft/botframework-cli into 308-luis-application-list
munozemilio
approved these changes
Nov 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.