Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parentheses are asymmetric #384

Closed
rickdgray opened this issue Oct 20, 2020 · 3 comments · Fixed by #402
Closed

Parentheses are asymmetric #384

rickdgray opened this issue Oct 20, 2020 · 3 comments · Fixed by #402
Labels
Issue-Feature

Comments

@rickdgray
Copy link

Description of the new feature/enhancement (with images if possible)

The parentheses are not symmetric across the x axis. I know this is trivial but, I'm sorry in my opinion it is very unpleasant and distracting to see. When paired next to each other as shown here, all I see is an incomplete heart shape.
image

Here's a screenshot of Fira Code's symmetric parentheses:
image
Ahh, much cleaner!

I think a font primarily designed for coding should really nail these common cases and this is a pretty painful one to see.
@DHowett
Copy link
Member

DHowett commented Oct 20, 2020

It would be helpful for you to include some or all of the info from the bug template (since you're reporting a bug, not a feature request).

Cascadia Code version number:
Application (with version) used to display text:
OS platform and version:
Screen resolution (i.e. 220dpi): 

Any other software?

I ask solely because...
image

image

...it would be very good to know what software has decided to render these parentheses incorrectly, and at what point size.

@rickdgray
Copy link
Author

Interesting, I didn't expect this to be a bug. Makes sense, though.

I'm using:

Cascadia Code PL version 2009.22
Visual Studio Pro 2019 version 16.7.6
Windows 10 Enterprise version 2004 build 19041.508
Screen Resolution is 1920x1080
The Scaling setting is set to 100%
In visual studio the point size is 10
In visual studio the zoom is set to 100%

I tried the same font and point size in notepad++ and don't have the same issue; it looks correct.

@aaronbell
Copy link
Collaborator

aaronbell commented Oct 20, 2020 •
edited
Loading

Cascadia Code has special code built in to help it render more clearly under certain conditions. Unfortunately, different applications (especially coding environments) do all sorts of fun things that can lead to inconsistencies in the rendering even with the special code.

In any case, I'll take a look and see if I can improve what is going on for those particular glyphs.

@aaronbell aaronbell mentioned this issue Feb 3, 2021
Merged
DHowett pushed a commit that referenced this issue Feb 9, 2021
@aaronbell
February 2021 update (#402)
00f3fd4 
This is a significant update to Cascadia Code including a large number
of bug fixes as well as updating the font to offer support for Fira
Code v5 ligature support. 

This update supersedes PR #373.

Closes #262 - ⏎ added
Closes #264 - additional codepoints for control characters added
Closes #281 - `!:` and `!.` added
Closes #290 - `/\` and `\/` added
Closes #301 - `??=` added
Closes #324 - ℞ added
Closes #327 - `<:>` and other variants implemented via the `calt`
  refactoring
Closes #359 - house added
Closes #371 - Added x-height instruction into ttfautohint to control the
  height of the lowercase.  
Closes #375 - Completely redesigned quote marks for better recognition
Closes #377 - updated hinting to achieve more consistent results
Closes #381 - increased height of thetamod
Closes #382 - reduced the width of the hooklefts
Closes #383 - updated heights on esh, glottalstop, glottalstopreversed
Closes #384 - tweaked hinting a little bit. Maybe it'll help :)
Closes #386 - added remaining soft-dotting
Closes #392 - changed designs of angled quotes (they are now round)
Closes #394 - changed former `~=` symbol to a simpler component-based
  version. Should be less confusing now for Lua / Matlab users. 
Closes #395 - makes the underline thicker based on font weight
Closes #400 - increased size of degree

Closes #219 
The full control pictures block has been added (u+2400 to u+2426). For
purposes of rendering, the two letter abbreviations have been used
instead of the standard three letter abbreviations:

Additionally, ss20 includes the oft-unused graphical representations of
these codepoints (for fun!):

Closes #276 (infinite arrows)
Full support for Fira Code's current ligature set (with a few
exceptions). Now featuring infinite arrows!!! 

This involved a full refactoring of the `calt` feature—for those
interested, it now uses forward-looking substitutions instead of
backward-looking substitutions and progressive substitution to reduce
code. This also required some redesigning of the greater / lesser
related ligatures. Please note, I have also removed all the obsolete
ligatures now covered by the arrows code.

Closes #329 
There was a mismatch in the font's postscript naming conventions that
was corrected. Should now render all weights in Word. **Note** there is
apparently an additional bug in Mac Word's implementation of variable
fonts which should be available in an update mid-Feb. 

* Not listed – Reworked the hints for the mod and superscript glyphs so
  that they're bottom-up rather than top-down. This allows for better
  bottom alignments. 

Aside from the above changes, this version also includes many other
small updates including spacing, outline quality improvements, and
fixing hinting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

February 2021 update aaronbell/cascadia-code
3 participants
@DHowett @rickdgray @aaronbell