Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump lxml from 4.5.2 to 4.6.2 #396

Merged
merged 1 commit into from
Feb 10, 2021
Merged

Bump lxml from 4.5.2 to 4.6.2 #396

merged 1 commit into from
Feb 10, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 7, 2021

Bumps lxml from 4.5.2 to 4.6.2.

Changelog

Sourced from lxml's changelog.

4.6.2 (2020-11-26)

Bugs fixed

  • A vulnerability (CVE-2020-27783) was discovered in the HTML Cleaner by Yaniv Nizry, which allowed JavaScript to pass through. The cleaner now removes more sneaky "style" content.

4.6.1 (2020-10-18)

Bugs fixed

  • A vulnerability was discovered in the HTML Cleaner by Yaniv Nizry, which allowed JavaScript to pass through. The cleaner now removes more sneaky "style" content.

4.6.0 (2020-10-17)

Features added

  • GH#310: lxml.html.InputGetter supports __len__() to count the number of input fields. Patch by Aidan Woolley.

  • lxml.html.InputGetter has a new .items() method to ease processing all input fields.

  • lxml.html.InputGetter.keys() now returns the field names in document order.

  • GH-309: The API documentation is now generated using sphinx-apidoc. Patch by Chris Mayo.

Bugs fixed

  • LP#1869455: C14N 2.0 serialisation failed for unprefixed attributes when a default namespace was defined.

  • TreeBuilder.close() raised AssertionError in some error cases where it should have raised XMLSyntaxError. It now raises a combined exception to keep up backwards compatibility, while switching to XMLSyntaxError as an interface.

Commits
  • 4cb5736 Work around Py2's lack of "re.ASCII".
  • c30106f Prepare release of 4.6.2.
  • a105ab8 Prevent combinations of <math/svg> and <style> to sneak JavaScript through th...
  • c053dc1 Add a recipe for a look-ahead generator to allow modifications during tree it...
  • b083124 lxml actually works in Py3.9.
  • 0f80590 lxml actually works in Py3.9.
  • fd8893c Add a doc note that the .find() methods are usually faster than one might exp...
  • eb6df27 Update release version on homepage.
  • 69b5c9b Automate the build artefact downloading from github and appveyor.
  • 61432a8 Prepare release of lxml 4.6.1.
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 7, 2021
@dependabot dependabot bot force-pushed the dependabot/pip/lxml-4.6.2 branch from 4f7cb4c to bc7339e Compare February 9, 2021 01:15
@WSLUser
Copy link

WSLUser commented Feb 10, 2021

@aaronbell @DHowett This update should be included in the new release as it addresses a CVE. Can you provide a new release that has this CVE vuln patch? Windows Terminal shouldn't be shipping with vulnerable code and right now this is the case.

@DHowett
Copy link
Member

DHowett commented Feb 10, 2021

@WSLUser er, a vulnerability in an XML parser used in the build system for a font (which only consumes known trusted input, not random attacker-controlled data) is not and never will be a security vulnerability in the compiled font files or any application that consumes them.

@DHowett DHowett closed this Feb 10, 2021
@dependabot @github

This comment has been minimized.

@DHowett DHowett reopened this Feb 10, 2021
@DHowett
Copy link
Member

DHowett commented Feb 10, 2021

A vulnerability (CVE-2020-27783) was discovered in the HTML Cleaner

This is a font. We aren’t even using the HTML cleaner. Given this and the above, this CVE is not a concern to this project or the Terminal project.

Bumps [lxml](https://github.com/lxml/lxml) from 4.5.2 to 4.6.2.
- [Release notes](https://github.com/lxml/lxml/releases)
- [Changelog](https://github.com/lxml/lxml/blob/master/CHANGES.txt)
- [Commits](lxml/lxml@lxml-4.5.2...lxml-4.6.2)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/pip/lxml-4.6.2 branch from bc7339e to af4a7bf Compare February 10, 2021 17:09
Copy link
Member

@miniksa miniksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We aren't using this functionality and I don't think this means that we need to spin a new version of the font or go servicing the old copy of the font because the inputs to our pipeline are trusted.

But I don't see any harm in revving it anyway for the next iteration and release.

@DHowett DHowett merged commit 8f5eea8 into main Feb 10, 2021
@DHowett DHowett deleted the dependabot/pip/lxml-4.6.2 branch February 10, 2021 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants