Arabic hinting fix #745
Closed
Arabic hinting fix #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Re-implements the CALT issue wherein LIG GSUB wouldn't work (this was lost during the fix. 2) Changes the STAT table generation library from statmake to gftools.stat, and all other necessary fixes.
Apparently this didn't get pushed up.
Adding Hebrew dflt language tag to ensure proper positioning.
At some point I added this line (or failed to remove it?), which actually causes issues in Jetbrains' capability to recognize the font on Windows devices. Changing the family name to "Cascadia Code Regular" resolves this issue.
removing "Medium" weight.
This update is primarily a bugfix update with improvements to Arabic as well as a variety of other small bugs / requests from the community. Another additional change is coming.
Forgot to add a couple of finals :/
1) Re-implements the CALT issue wherein LIG GSUB wouldn't work (this was lost during the fix. 2) Changes the STAT table generation library from statmake to gftools.stat, and all other necessary fixes.
removing "Medium" weight.
This update is primarily a bugfix update with improvements to Arabic as well as a variety of other small bugs / requests from the community. Another additional change is coming.
Correcting hinting on italic brace characters and ligatures
Added "original" versions, "processed" versions, and a script to convert from one to the other. Note these are not identical to the binaries on the NF website, nor is the positioning / scale the same as in the "officially" produced ones. But I don't think folks will mind :)
Build system now renames all of the added NF glyphs coming in to their unicode value. This avoids issues where the same name is used by multiple icon libraries for *reasons*.
This update is primarily a bugfix update with improvements to Arabic as well as a variety of other small bugs / requests from the community. Another additional change is coming.
1) Re-implements the CALT issue wherein LIG GSUB wouldn't work (this was lost during the fix. 2) Changes the STAT table generation library from statmake to gftools.stat, and all other necessary fixes.
removing "Medium" weight.
This update is primarily a bugfix update with improvements to Arabic as well as a variety of other small bugs / requests from the community. Another additional change is coming.
Correcting hinting on italic brace characters and ligatures
Added "original" versions, "processed" versions, and a script to convert from one to the other. Note these are not identical to the binaries on the NF website, nor is the positioning / scale the same as in the "officially" produced ones. But I don't think folks will mind :)
Build system now renames all of the added NF glyphs coming in to their unicode value. This avoids issues where the same name is used by multiple icon libraries for *reasons*.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
The point order of certain Arabic glyphs in the font changed, likely due to a newer version of the python libraries. The hinting has now been updated to reflect the new point order.
PR Checklist