Fix bugs in DAC names that either contain non-closed generics or non-assembly qualified names #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanmolden
changed the title
|
Sorry I have been on leave and will dig into this PR this week. Thank you for taking a look here! |
…assembly qualified names (see bug microsoft#897) Add lots of comments to parser as its complex due to having to deal with tragedies like the type name in ParseGenericWithComplexGenericArgs2 Replace uses of char literals in numerous places with their named constants I was using elsewhere Correct numerous comment spelling errors (thanks VS spell checker) Add numerous tests both for the case in 897, some variants of it, and another case I encountered internally
leculver
force-pushed
the
dev/rmolden/FixDACNameParserBug
branch
from
d722431
to
712c196
Compare
leculver
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix DAC name parser to deal with non-closed generic types and non-assembly qualified names (see bug #897).
Add lots of comments to parser as its complex due to having to deal with tragedies like the type name in the ParseGenericWithComplexGenericArgs2 test.
Replace uses of char literals in numerous places with their named constants I was using elsewhere.
Correct numerous comment spelling errors (thanks VS spell checker).
Add numerous tests both for the case in 897, some variants of it, and another case I encountered internally.
Add support for non-traditional generics as produced by FSharp and various obfuscators.