-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable white-listing features & tests and self-hosted agents #350
Conversation
Also fixes an issue with PNG files when developing Cobalt on Windows machines. Also has a couple temporary 'prefix' edits to isolate this work stream from the default AZ environment.
# Conflicts: # infra/templates/az-isolated-service-single-region/tests/unit/unit_test.go
(demand it is provided at runtime by users)
(demand it is provided at runtime by users)
(demand it is provided at runtime by users)
infra/templates/az-isolated-service-single-region/tests/unit/unit_test.go
Show resolved
Hide resolved
devops/providers/azure-devops/templates/infrastructure/scripts/tf-apply-plan.yml
Show resolved
Hide resolved
…ues aren't important)
@erikschlegel has pointed out that some solid integration tests, which check that the IP While Lists are as expected at Integration Test-time, are needed, and that's a great point. I'd suggest that such test get written as a follow-on tasks, given that the team chose the unit vs. integration test strategy for this PR, and this PR is blocking some other work. I do believe I know what needs to be written to enact the integration test that Erik's calling out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create a backlog item, not V1, for creating a whitelist integration test. 🚢 it
All Submissions:
What is the current behavior?
Resolves Issue Number: #339 and #341
What is the new behavior?
resource_ip_whitelist
must be provided by users (e.g. by settingTF_VAR_resource_ip_whitelist to
["x.x.x.x/32"], or via
*.tfvars`, etc). Build pipelines fail with a clear error, if a value is not provided.verifyIPWhitelistForACR
tests at .../acr.go and .../keyvault.gowere removed, in favor of the new IP White List testing in
az-isolated-service-single-region/tests/unit/unit_test.go`)Does this introduce a breaking change?